Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated BSkeleton to Vue 3 functional component as function #197

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

hirokiky
Copy link

@hirokiky hirokiky commented Feb 22, 2024

Proposed Changes

  • Migrated BSkeleton to Vue 3 functional component as function
  • Vue 3 won't allow to return empty values, so now it will return CommentVNode when deactivated

I refered ModelList.vue changes for this commit
buefy@f85445f

@kikuomax kikuomax self-requested a review February 23, 2024 03:38
@kikuomax kikuomax added the enhancement New feature or request label Feb 23, 2024
@kikuomax
Copy link
Collaborator

kikuomax commented Feb 23, 2024

@hirokiky Thank you for your PR!

Could you git rebase your branch on top of the latest dev? It should not cause any conflicts. Sorry for confusion, but we have changed the workspace structure from main.

@hirokiky
Copy link
Author

@kikuomax Thanks for your review!
I fixed it, but is it OK? If it's not, I'll create new Pull-Request.

@kikuomax
Copy link
Collaborator

@hirokiky Thanks for the updates. I remember functional components will cause a problem in production unless we carefully treat them. Could you also update the following line?

Like I did in:

// explicit `name` is needed to avoid name mangling of
// Functional Component in production
registerComponent(Vue, MenuList, 'BMenuList')

@hirokiky
Copy link
Author

@kikuomax Thank you!
I hope the change would help.

undefined/null will be normalized as comment VNode inside Vue runtime.
So we don't need to take care of it explicitly.
Copy link
Collaborator

@kikuomax kikuomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kikuomax kikuomax merged commit 5b09602 into ntohq:dev Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants