Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [Upload]: Vue Compat: deprecation INSTANCE_ATTRS_CLASS_STYLE (#16) #219

Merged
merged 4 commits into from
Mar 29, 2024

Commits on Mar 26, 2024

  1. feat(lib): add compat-fallthrough prop to Upload

    - `Upload` introduces a new prop `compat-fallthrough` which determines
      if the `class`, `style`, and `id` attributes are applied to the root
      `<label>` element or the underlying `<input>` element. Since Vue 3
      changed the fallthrough behavior, `Upload` became incompatible with
      that of Buefy for Vue 2. The default value of this prop is given by
      the `defaultCompatFallthrough` config option that is `true` by default
      (compatible with Buefy for Vue 2).
    
      Replaces the `classAndStyle` computed value with `rootAttrs`, which
      did not address the `id` attribute.
    kikuomax committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6ff2e3b View commit details
    Browse the repository at this point in the history
  2. test(lib): test Upload fallthrough behavior

    - Adds test cases for the `compat-fallthrough` prop of `Upload`
    kikuomax committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    aa11c97 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    49b757d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e9bddd3 View commit details
    Browse the repository at this point in the history