Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google_assistant_utils.lua #4689

Closed
wants to merge 2 commits into from
Closed

Add google_assistant_utils.lua #4689

wants to merge 2 commits into from

Conversation

RicterZ
Copy link
Contributor

@RicterZ RicterZ commented Nov 7, 2020

No description provided.

@RicterZ
Copy link
Contributor Author

RicterZ commented Nov 7, 2020

#4113

@lucaderi
Copy link
Member

lucaderi commented Nov 9, 2020

Hi @RicterZ Can you please explain how you plan to use this file as we do not natively support google assistant (it was just an experiment). Do you have some more info to share?

@RicterZ
Copy link
Contributor Author

RicterZ commented Nov 10, 2020

Hi @lucaderi
I developed some lua scripts by myself, some of them depends google_assistant_utils.lua, or modified from assistant_test.lua.
If it should been removed anyway, I hope it can be provided in the form of plugins or others something.

@lucaderi
Copy link
Member

@simonemainardi Can you please decide about this PR?

@simonemainardi
Copy link
Contributor

We cannot accomodate this PR as already discussed google assistant support was experimental and we won't be able to maintain it.

I would encourage @RicterZ to distribute the google assistant lua file along with the other scripts he has developed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants