add rev6-7 support #107
add rev6-7 support #107
Conversation
We still need more command C7 samples from users to safely determine r4ids.cn revisions.
|
sorry @zoogie. I attached my experimental changes. |
|
rev4-5 is broken now. This is wrong This is right |
1. fix whitespaces
2. merge all injection methods;
these methods just have little diffs(mostly offsets).
so added setting structure, then merge all logics
side effect:
- we need multiple read firm for the flash bf and firm header
- got warnings about designated initializers. I'm too lazy
3. extract injectFlash method; read~inject data~write chain
|
@zoogie yeah right. fixed my mistake. |
|
Alright, everything works now. LGTM |
|
@zoogie there's no need to go and explain specifically to me in the issues where you're asking these questions, it's fine. 😛 Might want to consider adding an enum to select the cart type, and also I think we're sticking with a relative include when including device.h, so LGTM! |
|
Best to stick with an include directive that is satisfied without assuming anything about the include paths defined by the application using us. i.e. |
Don't rely on the environment setting a directory as an include directory.
And maybe rev8 but I haven't seen anybody with this card yet.
We still need more command C7 samples from users to safely determine r4ids.cn revisions.
@d3m3vilurr knows what I mean by this. Might need to open some rev4-5 issues and ask users as I did here: #9 (comment)
But this did work for me on my 3 r4igolds and at least two other users on rev6 and 7. This should complete full support for the r4ids.cn : )