Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I created a pull request for pqm4 (mupq/pqm4/pull/181) with the stack optimizations for Saber NTT multiplication. I wanted to ask if you also want to fully include them here, or keep compatibility with the original paper?
Right now this draft pull request has the stack-optimized Saber NTT, but this one has a little different function naming than the Toom-Cook reference implementation that is also included. This messes up the testbenches. I could add an update for the Toom-Cook as well, to uniformize them.
Then there's a second problem that the stack-optimized implementation has no native
MatrixVectorMul
andInnerProd
. The new functions unpack the inputs just-in-time, depending on keygen/encrypt/decrypt. To keep all the benchmarksspeed.c
, these two functions should be recreated again.Let me know what you prefer!
Cheers,
Michiel