Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instancemonitor init.d #23

Merged
merged 2 commits into from Mar 24, 2016
Merged

Fix instancemonitor init.d #23

merged 2 commits into from Mar 24, 2016

Conversation

muroi
Copy link
Contributor

@muroi muroi commented Mar 22, 2016

File name of instancemonitor is 'masakari_instancemonitor.py' not
'masakari-instancemonitor.py'. The inconsistency causes service starting error.

File name of instancemonitor is 'masakari_instancemonitor.py' not
'masakari-instancemonitor.py'.
@sampathP
Copy link
Contributor

@muroi Thank you for fix.
This work with ubuntu.
though, one point we have to keep in mind.
In CentOS, process path of the instance_monitor is different.
rpm package puts the script as /usr/bin/masakari-instancemonitor and 'ps' output give something similar.
we have to make things consistent between rpm packaging and deb packaging.
For now, I thing its better to leave comment in proc.list.sample file, but im not sure processmonitor,sh can skip the comment lines in proc.list.

@muroi
Copy link
Contributor Author

muroi commented Mar 23, 2016

I agree anytime we should support CentOS. But we need to fix it ASAP since instancemonitor isn't working now.

Currently, processmonitor doesn't support comment line in proc.list, so we have 2 options to work it.

  1. Enables processmonirot to work with comment line in proc.list and adds the comment to proc.list.sample
  2. Just adds the comment line to proc.list
  3. Adds the comment line to proc.list and https://github.com/ntt-sic/masakari-deploy supports it

Thought?

@sampathP
Copy link
Contributor

Agree to fix this asap. If im correct, currently proc.list is deploy by ucf in debian postinst. Since processmonitor cant skip the comments, if we make commet in the file then it will make things more complex. So, my opnion is lets stick to original fix and raise an issue on github for centos. Sorry for made things coplex

@sampathP
Copy link
Contributor

#26 to address this issue for CentOS.

@sampathP sampathP merged commit bab72fd into master Mar 24, 2016
@muroi muroi deleted the fix-init.d branch April 6, 2016 02:04
@sampathP sampathP added the bug label Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants