Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPF for calculate dynamic path #23

Merged
merged 9 commits into from
Oct 17, 2022

Conversation

Motok1
Copy link
Contributor

@Motok1 Motok1 commented Oct 11, 2022

Function

  • Add simple Shortest Path First package for calculate Dynamic Path
  • Add the feature to create policies with dynamic paths using pola's TED
  • Extend pola cli commands for dynamic path calculation

Updated pola command

note: pola lsp command has been replaced by pola sr-policy command.

pola sr-policy add -f filename

*You need to enable TED when starting polad
-> See #21

input file example

asn: 65000
srPolicy:
    pcepSessionAddr: 192.0.2.1
    name: policy-name    
    srcRouterId: 0000.0aff.0001
    dstRouterId: 0000.0aff.0004
    color: 100
    type: dynamic 
    metric: igp / te / delay

pola sr-policy add -f filename --no-link-state

srPolicy:
    pcepSessionAddr: 192.0.2.1
    srcAddr: 192.0.2.1
    dstAddr: 192.0.2.2
    name: name
    color: 100
    segmentlist:
        - sid: 16003
          nai: 192.0.2.3
        - sid: 16002
          nai: 192.0.2.2

close #11

@Motok1 Motok1 requested a review from watal October 11, 2022 02:05
@Motok1 Motok1 force-pushed the feature/add_cspf_for_calculate_dynamic_path branch from f235c3c to 6211339 Compare October 11, 2022 08:37
@Motok1 Motok1 force-pushed the feature/add_cspf_for_calculate_dynamic_path branch from c1ab2a8 to 49567cb Compare October 11, 2022 10:28
@Motok1
Copy link
Contributor Author

Motok1 commented Oct 11, 2022

Select a gRPC server's IP and port optionally in the pola command.

Copy link
Member

@watal watal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. please confirm my comments about function names, logger handling, etc.

cmd/pola/README.md Outdated Show resolved Hide resolved
cmd/pola/README.md Outdated Show resolved Hide resolved
tools/grpc/go/show_session/show_session.go Outdated Show resolved Hide resolved
tools/grpc/go/show_sr-policy/show_sr-policy_list.go Outdated Show resolved Hide resolved
tools/grpc/go/show_ted/show_ted.go Outdated Show resolved Hide resolved
tools/grpc/go/add_sr-policy/add_sr-policy.go Outdated Show resolved Hide resolved
tools/grpc/go/add_sr-policy_no_ls/add_sr-policy_no_ls.go Outdated Show resolved Hide resolved
pkg/server/grpc_server.go Outdated Show resolved Hide resolved
@Motok1 Motok1 force-pushed the feature/add_cspf_for_calculate_dynamic_path branch 2 times, most recently from 1ed38b1 to e610e93 Compare October 14, 2022 05:14
@Motok1 Motok1 force-pushed the feature/add_cspf_for_calculate_dynamic_path branch from e610e93 to 2fd0b5d Compare October 17, 2022 06:42
@Motok1 Motok1 requested a review from watal October 17, 2022 09:16
@Motok1 Motok1 force-pushed the feature/add_cspf_for_calculate_dynamic_path branch from 00887ca to b618ac8 Compare October 17, 2022 09:41
Copy link
Member

@watal watal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@watal watal merged commit 5d8cf18 into main Oct 17, 2022
@watal watal deleted the feature/add_cspf_for_calculate_dynamic_path branch October 19, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dynamic path support
2 participants