Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PCE and PCEP library #39

Merged
merged 5 commits into from
Feb 5, 2023
Merged

Refactor PCE and PCEP library #39

merged 5 commits into from
Feb 5, 2023

Conversation

Motok1
Copy link
Contributor

@Motok1 Motok1 commented Feb 3, 2023

refactor

  • use net/netip package
  • Add struct of SRPolicy and interface of Segment
  • Add EroSubobject
    • Equal treatment of SREroSubobjects and SRv6-EroSubobjects

bug fixed

  • A lot of errors occur when ted is enabled but GoBGP is not actually running

@Motok1 Motok1 requested a review from watal February 3, 2023 16:21
watal
watal approved these changes Feb 5, 2023
View reviewed changes
Copy link
Member

@watal watal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@watal watal merged commit 2b79012 into main Feb 5, 2023
@watal watal deleted the refactor/PCEP_library branch February 5, 2023 23:22
@Motok1 Motok1 self-assigned this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watal watal watal approved these changes

Assignees

@Motok1 Motok1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Motok1 @watal