Support baremetal component #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| The following attributes are exported: | ||
|
|
||
| * `name` - See Argument Reference above. | ||
| * `admin_pass` - See Argument Reference above. |
There was a problem hiding this comment.
In ECL provider we defined following rules
- Argument is the section for the parameters which user can specify.
- Attributes section is for the parameters which has Computed=true.
In current implementation of this resource, no parameters are appeared in attributes section.
|
|
||
| log.Printf("[DEBUG] Retrieved Server %s: %+v", d.Id(), server) | ||
|
|
||
| d.Set("name", server.Name) |
There was a problem hiding this comment.
Why you only set name as state is, bare-metal API does not support Update. right?
But this may cause unexpected change in case updating configurations.
Under the condition that terraform only has server name as state, Terraform may not sense configuration change excepting name. (I can not say confidently)
To confirm it, could you please add ACC test to explicitly cause ForceNew change like compute server?
There was a problem hiding this comment.
As we discussed yesterday, I've removed state "name" because there is no update API:)
Data sources: * availability zone * flavor * keypair Resources: * keypair * server
keiichi-hikita
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data sources:
Resources: