fix acc tests for following resources. #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instance - Volume - Volume Attach - Port Reason of this change 1: Depending on specification change of HCL2, l HCL grammar for objects and list of objects are changed strictly. Reason of this change 2: Depending on OpenStack settings in each region default zone setting is needed to pass the tests.
ManabuMiwa
requested changes
Nov 29, 2019
| `, testCreateNetworkForInstance, OS_IMAGE_ID) | ||
| `, testCreateNetworkForInstance, | ||
| OS_DEFAULT_ZONE, | ||
| OS_DEFAULT_ZONE, |
There was a problem hiding this comment.
OS_DEFAULT_ZONE を2つ渡しています。 これは大丈夫でしょうか。
There was a problem hiding this comment.
はい、別なリソースに対する渡し方なので問題ないかと。
あとSptinfのプレースホルダーそれぞれに渡しているという意味になります。
ManabuMiwa
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason of this change 1:
Depending on specification change of HCL2, l
HCL grammar for objects and list of objects are
changed strictly.
Reason of this change 2:
Depending on OpenStack settings in
each region default zone setting is needed
to pass the tests.