Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete ecl_db (#35) #36

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Delete ecl_db (#35) #36

merged 2 commits into from
Dec 6, 2019

Conversation

shimisho
Copy link
Contributor

@shimisho shimisho commented Dec 5, 2019

The file of ecl_db that is not provided by ECL has been deleted.

Comment on lines 22 to 23
OS_DB_DATASTORE_TYPE = os.Getenv("OS_DB_DATASTORE_TYPE")
OS_DB_DATASTORE_VERSION = os.Getenv("OS_DB_DATASTORE_VERSION")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably these are not necessary too:)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no part which is using, it deletes. Thank you.

Copy link

@t-wata t-wata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍡

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shimisho shimisho merged commit 263f2e0 into master Dec 6, 2019
@shimisho shimisho deleted the delete_ecl_db branch December 6, 2019 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants