Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tfproviderlint errors #40

Merged
merged 5 commits into from
Dec 24, 2019
Merged

Fix tfproviderlint errors #40

merged 5 commits into from
Dec 24, 2019

Conversation

kazyshr
Copy link
Contributor

@kazyshr kazyshr commented Dec 23, 2019

Make changes to resolve errors by tfproviderlint

  • Add make target to run tfproviderlint
  • Rename test functions to resolve AT003 errors
  • Remove provider configuration in test templates to resolve AT004 errors

tfproviderlint details:
https://github.com/bflad/tfproviderlint

keiichi-hikita
keiichi-hikita approved these changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@keiichi-hikita keiichi-hikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@ManabuMiwa ManabuMiwa self-requested a review December 24, 2019 02:59
ManabuMiwa
ManabuMiwa approved these changes Dec 24, 2019
View reviewed changes
Copy link

@ManabuMiwa ManabuMiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed to be able to understand what's going on here (Especially in resource_ecl_imagestorages_member_accepter_v2_test).
LGTM! :)

@kazyshr kazyshr merged commit 7dc3088 into master Dec 24, 2019
@kazyshr kazyshr deleted the fix_tfproviderlint_errors branch December 24, 2019 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManabuMiwa ManabuMiwa ManabuMiwa approved these changes

@keiichi-hikita keiichi-hikita keiichi-hikita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kazyshr @ManabuMiwa @keiichi-hikita