Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile as GNUmakefile #49

Merged
merged 3 commits into from
Feb 21, 2020
Merged

Conversation

keiichi-hikita
Copy link
Contributor

@keiichi-hikita keiichi-hikita commented Feb 19, 2020

Rnema Makefile as GNUmakefile and fix this file like followings.

  • Add tfproviderlint installation into tools section
  • Add golangci-lint in lint section according to other major providers
  • Add website relevant functionalities

According to Terraform Developer program review result,
makefile name must be GNUmakefile
- Add tfproviderlint installation into tools section
- Add golangci-lint in lint section according to other major providers
- Add website relevant functionalities
Copy link

@t-wata t-wata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍎

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@keiichi-hikita keiichi-hikita merged commit 7d7308d into master Feb 21, 2020
@keiichi-hikita keiichi-hikita deleted the hikita/IF-4540_fix_makefile branch February 21, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants