Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix volume resource to enable image_name #52

Merged
merged 1 commit into from
Mar 31, 2020
Merged

fix volume resource to enable image_name #52

merged 1 commit into from
Mar 31, 2020

Conversation

keiichi-hikita
Copy link
Contributor

  • add image_name parameter
  • add test case
    • to use image_name
    • to use both image_id and image_name

@keiichi-hikita
fix volume resource to enable image_name
3f9af1d 
- add image_name parameter
- add test case
  - to use image_name
  - to use both image_id and image_name
ghost
ghost approved these changes Mar 26, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

ManabuMiwa
ManabuMiwa approved these changes Mar 31, 2020
View reviewed changes
Copy link

@ManabuMiwa ManabuMiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@keiichi-hikita keiichi-hikita merged commit fe26490 into master Mar 31, 2020
@keiichi-hikita keiichi-hikita deleted the hikita/IF-4676_fix_compute_volume_acc branch March 31, 2020 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManabuMiwa ManabuMiwa ManabuMiwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keiichi-hikita @ManabuMiwa