Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mock tests run anywhere #62

Merged
merged 3 commits into from
Apr 28, 2020
Merged

Make mock tests run anywhere #62

merged 3 commits into from
Apr 28, 2020

Conversation

kazyshr
Copy link
Contributor

@kazyshr kazyshr commented Apr 27, 2020

  • Make mock tests run in production regions by changing keystone response dynamically
  • Remove skip logic of mock tests
  • Fix mail address value in TestMockedAccSecurityV1HostBased_basic

keiichi-hikita
keiichi-hikita approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@keiichi-hikita keiichi-hikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM o/

shimisho
shimisho approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@shimisho shimisho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)
As a suggestion, how about adding a test skipping process to TestAccNetworkV2InternetServiceDataSource in short mode?
You don't have to do it if you think it is unnecessary.

@kazyshr
Copy link
Contributor Author

kazyshr commented Apr 28, 2020 •
edited
Loading

@shimisho

LGTM:)
As a suggestion, how about adding a test skipping process to TestAccNetworkV2InternetServiceDataSource in short mode?
You don't have to do it if you think it is unnecessary.

This test case is covered by mock test. So I added skip logic

@kazyshr kazyshr merged commit 992f9db into master Apr 28, 2020
@kazyshr kazyshr deleted the make_mock_tests_run_anywhere branch April 28, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keiichi-hikita keiichi-hikita keiichi-hikita approved these changes

@shimisho shimisho shimisho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kazyshr @keiichi-hikita @shimisho