Added config_drive description to docs #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yapoo-t
approved these changes
May 29, 2020
t-wata
suggested changes
May 29, 2020
There was a problem hiding this comment.
I think this explanation is a little bit inadequate.
The config_drive does not simply enable a general ephemeral disk, but has the purpose of referencing metadata in particular.
Also, since this parameter is optional, it would be helpful to have a mention of the default value.
|
@t-wata Added more detailed description of config_drive. Please confirm. |
t-wata
suggested changes
May 29, 2020
Comment on lines
150
to
151
| * `config_drive` - (Optional) true is specified, can set to write metadata | ||
| to the ephemeral drive. Defaults to false. |
There was a problem hiding this comment.
Suggested change
| * `config_drive` - (Optional) true is specified, can set to write metadata | |
| to the ephemeral drive. Defaults to false. | |
| * `config_drive` - (Optional) If true is specified, a configuration drive will be mounted | |
| to enable metadata injection in the server. Defaults to false. |
There was a problem hiding this comment.
Thank you. I fixed it like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added description of config_drive to docs.