Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VNA plan #94

Merged
merged 14 commits into from
Apr 27, 2022
Merged

Support VNA plan #94

merged 14 commits into from
Apr 27, 2022

Conversation

kajiuray
Copy link
Contributor

This is a commit corresponding to eclcloud#38.
The user will be able to create a VNA by indicating some of plan's attribute like id and name.

This PR includes follows.

  • Add ecl_vna_appliance_plan_v1 data type
  • Add a related document
  • Add tests

Ref:
https://sdpf.ntt.com/services/docs/firewall/api-references/rsts/APIList/source/list_virtual_network_appliance_plan.html

Copy link
Contributor

@ysssasaki ysssasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on the Mock test.
I will also comment on regular tests later 🙇

ecl/data_source_ecl_vna_appliance_plan_v1_mock_test.go Outdated Show resolved Hide resolved
ecl/data_source_ecl_vna_appliance_plan_v1_mock_test.go Outdated Show resolved Hide resolved
ecl/data_source_ecl_vna_appliance_plan_v1_mock_test.go Outdated Show resolved Hide resolved
ecl/data_source_ecl_vna_appliance_plan_v1_mock_test.go Outdated Show resolved Hide resolved
ecl/data_source_ecl_vna_appliance_plan_v1_mock_test.go Outdated Show resolved Hide resolved
ecl/data_source_ecl_vna_appliance_plan_v1_test.go Outdated Show resolved Hide resolved
ecl/data_source_ecl_vna_appliance_plan_v1_test.go Outdated Show resolved Hide resolved
ecl/data_source_ecl_vna_appliance_plan_v1_test.go Outdated Show resolved Hide resolved
ecl/data_source_ecl_vna_appliance_plan_v1_test.go Outdated Show resolved Hide resolved
ecl/data_source_ecl_vna_appliance_plan_v1.go Outdated Show resolved Hide resolved
ecl/data_source_ecl_vna_appliance_plan_v1.go Outdated Show resolved Hide resolved
kajiuray and others added 12 commits April 27, 2022 10:16
Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com>
Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com>
Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com>
Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com>
Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com>
Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com>
Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com>
Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com>
Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com>
Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com>
Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com>
Co-authored-by: ysssasaki <64194789+ysssasaki@users.noreply.github.com>
@ysssasaki ysssasaki merged commit e8499ec into nttcom:master Apr 27, 2022
@kajiuray kajiuray deleted the support_vna_plan branch May 9, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants