Change station time #520
Change station time #520
Conversation
…at is not controlled/converted during setting but only during getting. This makes the code more readable but the state interally is undefined (but its only the format)
fschlueter
force-pushed
the
change_station_time
branch
from
cab6e95
to
027aa09
Compare
Allow to set station._station_time = None
Fix Sjoerds comments
Add format to interface
…problems and is probably inefficient).
|
I realised that the station_time is also stored in the event_header of a nur file but as astropy object (which is a bad idea and was already changed for the actual station serialisation). I fixed that but for reading allow backwards compatibility. I removed this weird set BTW, what is stored in the parameter station_time (21)? It is not actually used to store the station time, right? But then it is used for the event header as dict key? |
|
Do we want to bump the nur file version for these changes? |
There was a problem hiding this comment.
I didn't realise that we already did things this way in base_station.py, so that this is basically just a fix for the event_header. I think this can be merged without further ado.
One thing I'm not entirely sure about is if we currently actually have ~ns level precision on the station time. E.g. if I set an astropy.time.Time object with a np.float128 and then call .value, it seems to return a np.float64 object with the associated loss in precision by default. But I think that is a separate issue.
Do you like this change?
I think it makes the setter more readable and also allows to set unix time stamps. However, now the format with which it is stored is not fixed anymore. I do not see why this is a problem but maybe someone can correct me.