Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further LOFAR development #656

Draft
wants to merge 100 commits into
base: develop
Choose a base branch
from
Draft

Further LOFAR development #656

wants to merge 100 commits into from

Conversation

MijnheerD
Copy link
Collaborator

This is a draft PR to follow up on the newest additions from the LOFAR side. These should mainly concern LOFAR specific modules, except for some framework changes that might happen do accommodate LOFAR specific requirements.

karenterveer and others added 30 commits July 13, 2023 15:01
@karenterveer
Update channelGalacticNoiseAdder.py
9d63122 
Included various sky models, moved sky noise generation out of run and into begin procedure
@MijnheerD
Read channel_group_id from Detector in LOFAR reader
e87020f
@MijnheerD
Read channels from Event rather than Detector to avoid selecting flag…
1a66d93 
…ged antennas
@MijnheerD
Relative calibration clarification
1bc2eb3
@MijnheerD
Ensure LORA zenith and azimuth are within expected range
d17aa03
@MijnheerD
Removed print statement and refactoring
fee4d6b
@MijnheerD
Added option to make LOFAR antenna model for X/Y dipoles
7273b33
@MijnheerD
Restructuring relative calibration code
a7b045d
@MijnheerD
Updates to beamformingDirectionFitter_LOFAR.py - needs further testing
298a45d
@MijnheerD
Add files with LOFAR calibration coefficients
a99c958
@karenterveer
Added LOFAR JSON including inner LBA, removed reference channels
8289274
@karenterveer
Added LOFAR detector file
3e6ff35 
Including LBA inner and removed reference channels
@karenterveer
Implemented ant_mode key in Detector description
0b7e65c
@karenterveer
specified get_antenna_mode docstring
7aa7396
@karenterveer
added conversion functions for tbb ID to nrr channel ID
d5989e1
@karenterveer
included get_antenna_mode, updated docstring
c0a15c7
@karenterveer
Update channelGalacticNoiseAdder.py
38a099a
@MijnheerD
Extended docstrings + reformatting for PEP8 compliance
cd54549
@karenterveer
updated relative calibration to get channel polarisation from ant ori…
f55d893 
…entation
@karenterveer
fixed reader to only loop over channels of given antenna set
060f762 
So far, only LBA_inner and LBA_outer were implemented as antenna sets. This can be extended further in the future.
@karenterveer
added astropy.Time import to update detector time
d162734
@karenterveer
fixed commission and deployment times
6ac19fe
@MijnheerD
Update TBB path on COMA
91facb4
@MijnheerD
Update TBB path on COMA
360d43c
@karenterveer
fixed antenna_set location and definition
88c93b2
@MijnheerD
Merge remote-tracking branch 'origin/lofar/lba_inner' into lofar/lba_…
07c8f58 
…inner
@MijnheerD
Streamlined timestamps + refactoring
41bbb95
@MijnheerD
Get channel polarisation from Detector
1fda764
@MijnheerD
Only use metadata if station has files
e9cfc65
@karenterveer
set station time, fixed channel IDs for inner and outer
e4352ed
karenterveer and others added 30 commits April 18, 2024 16:11
@karenterveer
added hardwareResponseIncorporator for LOFAR
6c57e8f
@karenterveer
upload files
a08494a
@karenterveer
upload cable attenuation files
c4b27c6
@karenterveer
added try-except statements to make sky model module installation opt…
fd28eeb 
…ional
@karenterveer
Create README.md
7f32002
@MijnheerD @karenterveer
Corrected sparse antenna layouts in rawTBBio_metadata.py
3ffefae
@karenterveer
added cable lengths and type
143d1e2
@karenterveer
logging
3df5612
@karenterveer
Merge branch 'lofar/development' into lofar/signalchain
f328661
@karenterveer
Merge pull request #674 from nu-radio/lofar/signalchain
194783f 
Add LOFAR signal chain
@MijnheerD
Added docstring + refactoring
6cfef25
@MijnheerD
Cleanup imports + add attributes to init
6bf60c0
@MijnheerD
Restructured try block
0a0e0a1
@MijnheerD
Simplify interpolation freq expression
02147b3
@MijnheerD
Merge pull request #670 from nu-radio/feature/galacticNoiseAdderUpgrade
a4b8b75 
Add support for other sky models in channelGalaticNoiseAdder
@MijnheerD
Raise IndexError when TBB file does not contain enough samples to ret…
73c34b3 
…urn entire block
@MijnheerD
Fix datatypes in flagged channel sets
c479b72
@MijnheerD
Ensure both channels are removed when a channel cannot be read in pro…
0a55cf0 
…perly
@MijnheerD
Switch integer type channel group ID for consistency with Detector de…
a0ed035 
…scription
@MijnheerD
Remove channels after loop to avoid modifying dicts in iteration
5662b22
@MijnheerD
Make LOFAR reader return calibration delays as dictionary per station
e37283f
@MijnheerD
Skip TBB files from remote stations on read-in
933a0ea
@MijnheerD
Use channel list from TBB file instead of Detector description
bcf5ccb
@MijnheerD
Add more specific exception when reading data
4126ca0
@MijnheerD
Fix channel group ID assumption
ad35a0b
@MijnheerD
Get metadata from all TBB files for a station
58be2f3
@MijnheerD
Save blocks which cannot be read for antenna
516afd3
@MijnheerD
Flagged TBB channel IDs must be str to compare to names from rawTBBio
b1c30c2
@karenterveer
Merge pull request #679 from nu-radio/lofar/hotfixes
9f50e98 
LOFAR reader hotfixes
@MijnheerD
Clarified docstrings
d90b7f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MijnheerD MijnheerD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MijnheerD @karenterveer @fschlueter