Skip TBB files from remote stations on read-in #668
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being addressed
When globbing over all TBB files in the directory, it is possible for a bunch of remote station files to be included in the
all_tbb_files
list. When doing the pattern matchingon those files, the result is an empty list. When then calling the first element, the reader crashes.
Proposed solution
I changed the code to either take the first element of the resulting list, or default to None in case the list is empty. If the
station_name
isNone
, the file is assumed to be from a remote station and skipped. Is this desired behavior? Should we explicitly check that the pattern "RS\d\d\d" does appear in the file name and do something else with it?