change get_channel_group_id to return channel id if no group_id is set #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschlueter
reviewed
May 28, 2024
MijnheerD
reviewed
May 28, 2024
| @@ -967,10 +967,10 @@ def get_channel_group_id(self, station_id, channel_id): | |||
| """ | |||
| res = self.__get_channel(station_id, channel_id) | |||
| if 'channel_group_id' not in res.keys(): | |||
| logger.warning( | |||
| 'Channel group ID not set for channel {} in station {}, returning -1'.format( | |||
| logger.info( | |||
There was a problem hiding this comment.
I agree with you that warning is a bit much, but maybe info is too little? Not sure. I think STATUS would be optimal actually, as that would still show up in the logs by default in the new system. Though for that we need to wait until the new logging is done :)
cg-laser
previously approved these changes
May 28, 2024
There was a problem hiding this comment.
looks good. I thought we already had this implemented. (Maybe I only did it on the refactor branch)
I would not even log an info method. This is a robust way for writing modules that work with antenna group and without, so we don't want to get flushed with log messages for an expected behaviour.
fschlueter
approved these changes
May 31, 2024
lpyras
force-pushed
the
change_return_ch_group_id
branch
from
8491a4d
to
d001c03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the function get_channel_group_id to return the channel id if no group id is set. The group_ids describe antennas are set for antennas with the same positions. Looping over the group_ids instead of the channel_ids and assign a quantity to several station ids can therefore be faster. The channel_id is more specific, therefore returning the channel id if no group id is set should not cause problems.