Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libfdk-aac detection improvements #60

Closed
TurtleWilly opened this issue May 5, 2024 · 2 comments
Closed

libfdk-aac detection improvements #60

TurtleWilly opened this issue May 5, 2024 · 2 comments

Comments

@TurtleWilly
Copy link

TurtleWilly commented May 5, 2024

fdkaac's configure doesn't detect a installed libfdk-aac:

…
checking for endian.h... no
checking for byteswap.h... no
checking for fdk-aac/aacenc_lib.h... no
configure: error: libfdk-aac is required

Ideally it simply should utilize pkg-config for detection (the library installs a proper .pc file), e.g. on my system:

$ pkg-config --libs --cflags fdk-aac
-I/usr/local/silo/libfdk-aac/latest/include -L/usr/local/silo/libfdk-aac/latest/lib -lfdk-aac

Alternatively the generated configure script should have a --with-libfdk-aac=<dir> option for verbosity and an easy direct way to specify a custom location to the library and its required components.

As it is now I need to manually patch up CPPFLAGS/CFLAGS, LDFLAGS, and LIBS variables to make detection work.

nu774 added a commit that referenced this issue May 5, 2024
nu774 added a commit that referenced this issue May 5, 2024
@nu774
Copy link
Owner

nu774 commented May 5, 2024

Thanks, fixed on 1.0.6.

@TurtleWilly
Copy link
Author

I tested the changes and it seems to work perfectly. Awesome!

…
checking for endian.h... no
checking for byteswap.h... no
checking for pkg-config... /usr/local/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for fdk-aac... yes
checking for inline... inline
checking whether byte ordering is bigendian... no
…
…
$ otool -L fdkaac
fdkaac:
	/usr/local/silo/libiconv/latest/lib/libiconv.2.dylib (compatibility version 9.0.0, current version 9.1.0)
	/usr/local/silo/libfdk-aac/latest/lib/libfdk-aac.2.dylib (compatibility version 3.0.0, current version 3.3.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1226.10.1)

Thanks for the quick support! 👍

@nu774 nu774 closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants