fix trivial but serious bug in configure.ac #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPPFLAGS is for C preprocessing, not C++ compilation. setting -std=c++11 here causes this flag to be used with the C compiler. more importantly, it causes CPP=/lib/cpp to be inferred, at least on Mac, and this does not work at all.
jeffhammond
added a commit
to jeffhammond/bagel
that referenced
this pull request
Jan 8, 2017
|
I am not sure why this is there. The previous line must be setting CXXFLAGS (see m4/ax_cxx_compile_stdcxx_11.m4), so best to remove this line instead. |
|
I haven't tested it, but that sounds better, since it will allow the C++11 macro to set the appropriate C++11 flag, not just the one that works for GCC, Clang and Intel. |
|
I implemented your suggested fix and merged with master. |
|
Thanks much! |
shiozaki
added a commit
that referenced
this pull request
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPPFLAGS is for C preprocessing, not C++ compilation. setting
-std=c++11 here causes this flag to be used with the C compiler.
more importantly, it causes CPP=/lib/cpp to be inferred, at least on
Mac, and this does not work at all.