Run tests with Python 3.9 #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 29, 2022 08:28
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
- Coverage 94.69% 94.28% -0.41%
==========================================
Files 25 32 +7
Lines 1507 1942 +435
Branches 203 258 +55
==========================================
+ Hits 1427 1831 +404
- Misses 48 76 +28
- Partials 32 35 +3
Continue to review full report at Codecov.
|
tatasz
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Background context
Some libraries are dropping support to Python 3.6, such as pip, so we need to prepare to support later versions of Python.
Description of the changes proposed in the pull request
Add test in CircleCI to run in an image with Python 3.9. A new version doesn't have to be released, because only test files were modified.
Where should the reviewer start?
File
.circleci/config.ymlthen the Python files.Remaining problems or questions
The step "Install package" takes about 10 minutes to run in Python 3.9, probably due to
scikit-learn(in Python 3.6 they take ~1 minute); and the unit tests take ~15 minutes (in Python 3.6 they take ~1 minute).