Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including LGBM parameters to lgbm_classification_learner #211

Merged
merged 5 commits into from
Oct 19, 2022

Conversation

nicolas-behar
Copy link
Contributor

@nicolas-behar nicolas-behar commented Sep 2, 2022

Status

IN DEVELOPMENT

Todo list

Background context

Some of the already implemented LGBM parameters can't be used by the lgbm_classification_learner function.

Description of the changes proposed in the pull request

We are including these parameters by changing the lgbm.train call function with these parameters, that can be passed by the user if needed.

Related PRs

#197

@nicolas-behar nicolas-behar requested a review from a team as a code owner September 2, 2022 22:47
@nicolas-behar nicolas-behar added the wip Work in progress label Sep 2, 2022
@nicolas-behar nicolas-behar added review-request Waiting to be reviewed and removed wip Work in progress labels Sep 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #211 (4e5837e) into master (3cd7bec) will decrease coverage by 0.35%.
The diff coverage is 93.19%.

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   94.69%   94.33%   -0.36%     
==========================================
  Files          25       34       +9     
  Lines        1507     2120     +613     
  Branches      203      280      +77     
==========================================
+ Hits         1427     2000     +573     
- Misses         48       83      +35     
- Partials       32       37       +5     
Impacted Files Coverage Δ
src/fklearn/causal/validation/cate.py 0.00% <0.00%> (ø)
src/fklearn/data/datasets.py 100.00% <ø> (ø)
src/fklearn/tuning/parameter_tuners.py 79.48% <ø> (ø)
src/fklearn/tuning/selectors.py 90.47% <ø> (ø)
src/fklearn/validation/validator.py 91.20% <88.88%> (-3.08%) ⬇️
src/fklearn/preprocessing/splitting.py 95.00% <92.59%> (-0.84%) ⬇️
src/fklearn/causal/cate_learning/meta_learners.py 93.02% <93.02%> (ø)
src/fklearn/training/calibration.py 96.36% <94.73%> (-3.64%) ⬇️
src/fklearn/training/transformation.py 93.95% <95.12%> (+0.02%) ⬆️
src/fklearn/validation/evaluators.py 93.95% <96.29%> (+4.32%) ⬆️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/fklearn/training/classification.py Outdated Show resolved Hide resolved
src/fklearn/training/classification.py Outdated Show resolved Hide resolved
Copy link
Contributor

@eduardodx eduardodx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@fabiofabris fabiofabris merged commit 79f150a into master Oct 19, 2022
@fabiofabris fabiofabris deleted the include-lgbm-parameters branch October 19, 2022 12:36
@fpingas fpingas mentioned this pull request Apr 11, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-request Waiting to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categorical Features in lgbm_classification_learner not working
4 participants