deprecate midje support #174
Conversation
dchelimsky
force-pushed
the
dc/midje-scope-provided
branch
from
ced701a
to
4cd7d95
Compare
dchelimsky
changed the title
dchelimsky
force-pushed
the
dc/midje-scope-provided
branch
from
770ca47
to
9eb4dbd
Compare
| @@ -0,0 +1,80 @@ | |||
| {:hooks {:analyze-call {midje.sweet/tabular marick.midje/tabular}} | |||
There was a problem hiding this comment.
@borkdude do you know if committing these configs here in combination with tagging midje as :scope "provided" in the matcher-combinators deps mean that the midje configs for clj-kondo would be still be picked up via clj-kondo --lint $(clojure -Spath) --dependencies --copy-configs ?
Like does --copy-configs copy all .clj-kondo configs from a lib even if it is from a different org namespace?
There was a problem hiding this comment.
No, that won't cause configs to be copied. Only configs under resources/clj-kondo.exports are copied. The .clj-kondo directory isn't part of the distributed jar of this library.
CHANGELOG.md
Outdated
| @@ -3,6 +3,12 @@ All notable changes to this project will be documented in this file. This | |||
| change log follows the conventions of | |||
| [keepachangelog.com](http://keepachangelog.com/). | |||
|
|
|||
| ## [3.6.1] | |||
| - deprecate the matcher-combinators.midje ns and functions in it | |||
There was a problem hiding this comment.
Fun to imagine this resulting in tens of thousands of new "deprecated" lint warnings in the test suites that Nubank still hasn't migrated away from Midje. Maybe this will help stoke the fire :P
There was a problem hiding this comment.
Nobody cares about deprecation warnings except @acamargo and me.
|
maybe (too) dirty, but we could also move all the midje-related matcher-combinator stuff into midje itself, but still under the same |
|
Documenting here for clarity: Newer PR #197 deleted |
scottbale
changed the title
scottbale
changed the title
CHANGELOG.md
Outdated
| - move midje dependency to :scope "provided" | ||
| - this eliminates the transitive dep for those not using midje features |
There was a problem hiding this comment.
These two lines are no longer valid. #197 (since merged into this PR) removed project.clj and effectively already removed midje as a transitive dependency.
|
@philomates I updated the CHANGELOG and README. Please re-review. If it's good for you I'll go ahead and merge it. |
Problem
Within Nubank, we've standardized on
clojure.testand deprecated the use ofmidje. Users who don't rely on midje support incur a transitive dependency on midje anyway.Solution
matcher-combinators.midjenamespace and its functions as deprecatedmove midje dependency to :scope "provided"(midje has been moved to:extra-depsof:devalias, see migrate to deps.edn #197)Rationale
We don't intend to maintain midje support within this library any longer. We have no plan to remove the
matcher-combinators.midjenamespace outright, so those who depend on it will continue to work as before as long as you maintain an explicit dependency on it.