Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message when last arg to flow is a vector #128

Merged
merged 2 commits into from Jun 8, 2020

Conversation

dchelimsky
Copy link
Contributor

@dchelimsky dchelimsky commented Jun 8, 2020

This PR addresses issue #113

Before

(flow "description" [x (state/get-state)])
;; Unexpected error (AssertionError) macroexpanding cats.core/do-let at (....).
;; Assert failed: Last argument of do-let must not be a vector
;; (not (vector? (last forms)))

After

(flow "description" [x (state/get-state)])
;; Syntax error macroexpanding state-flow.core/flow at (...).
;; The last argument to flow must be a flow/step, not a binding vector.

@dchelimsky dchelimsky marked this pull request as ready for review June 8, 2020 16:30
@dchelimsky dchelimsky requested a review from a team June 8, 2020 16:30
@dchelimsky
Copy link
Contributor Author

Thanks @philomates

@dchelimsky dchelimsky merged commit ea483e5 into master Jun 8, 2020
@dchelimsky dchelimsky deleted the dc/improve-error-message branch June 8, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants