Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should DraxView longPressDelay default to 0? #11

Closed
lafiosca opened this issue Jan 13, 2020 · 1 comment
Closed

Should DraxView longPressDelay default to 0? #11

lafiosca opened this issue Jan 13, 2020 · 1 comment
Labels
defaults Related to the library's "sensible default" value and behaviors

Comments

@lafiosca
Copy link
Contributor

Currently, there's a default longPressDelay of 250ms on DraxView:

export const defaultLongPressDelay = 250;

Why? I mean, I know why as the author: the initial use case was to implement a drag-reorderable list, which meant that I needed the delay to prevent the drags from capturing list scroll gestures. But for the standard DraxView use case, might we not want to default to 0, which allows instant grabbing of the view to drag?

One possible counterpoint would be when the draggable views may have standard Touchable buttons embedded in them. The longPressDelay prevents the drag from hijacking those touches. But it can be lowered a little bit for that case as well. The 250ms value came from what "felt right" for reorderable lists.

@lafiosca lafiosca added the defaults Related to the library's "sensible default" value and behaviors label Jan 13, 2020
@lafiosca
Copy link
Contributor Author

Let's change the DraxView default delay to 0 but leave it at 250 for items in a DraxList.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defaults Related to the library's "sensible default" value and behaviors
Projects
None yet
Development

No branches or pull requests

1 participant