Skip to content

Commit

Permalink
Add footstep sound when walking or running (#41)
Browse files Browse the repository at this point in the history
* Bogus commit

* Hook up sounds

* Update process

* Update prefabs

* Get rid of unused event

* Move some stuff around to make more sense

* More moving code around

* Remove Footstep as it is multiple sounds in one

* Update readme

* Update readme

* Update process

* Update process
  • Loading branch information
nucleartide committed Apr 4, 2023
1 parent 8437989 commit 04cde90
Show file tree
Hide file tree
Showing 16 changed files with 19,820 additions and 19 deletions.
15 changes: 8 additions & 7 deletions .github/PULL_REQUEST_TEMPLATE/add_sound_effect.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
## Pipeline

1. [ ] Find a sound effect from freesound.org. (I like this most currently, no need to download nor pay for huge asset pack.)
1. [ ] Find a sound effect from freesound.org.
2. [ ] Check the sound's license to ensure that I can use it.
3. [ ] Import sound into `Sounds/` folder.
4. [ ] Update `Sounds/Attribution.md` doc. Give credit where it's due!
5. [ ] Expose new reference in the `AllTheSounds` ScriptableObject, and hook up the `AudioClip`.
6. [ ] Expose game event for when you want the sound to be played.
* For example, the `PlayerAnimationEvents` script exposes player animation events to C#.
7. [ ] Make `SoundManager` listen to the new game event, and play the corresponding sound when the event occurs.
4. [ ] Update `Sounds/Attribution.md` doc.
5. [ ] Expose new reference in the `AllTheSounds` ScriptableObject, and hook up the `AudioClip`. Alternatively, if you want to play the sound as its own AudioSource, then create the AudioSource and hook up the `AudioClip`.
6. [ ] Add test methods to `SoundManager` (or a separate script) that play the sound. If the audio clip is split into many sections, identify sections within the audio clip to play with the `AudioClipSection` class, then use `AudioSourceHelpers.PlaySoundInterval`.
7. [ ] Expose game event for when you want the sound to be played. For example, the `PlayerAnimationEvents` script exposes player animation events to C#.
8. [ ] Make `SoundManager` (or your separate script) listen to the new game event, and call the corresponding play-sound method when the event occurs.
9. [ ] Update readme with pull request link.

## Alternatives
## Future alternatives to consider

* bfxr.net
* Purchase a reputable (not stolen, like Sidearm Studios') sound effect pack on the Asset Store
Expand Down
Loading

0 comments on commit 04cde90

Please sign in to comment.