Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mine sound effect + sound effect process #40

Merged
merged 8 commits into from
Apr 4, 2023

Conversation

nucleartide
Copy link
Owner

@nucleartide nucleartide commented Mar 31, 2023

Important stuff is over here:

## Pipeline
1. [ ] Find a sound effect from freesound.org. (I like this most currently, no need to download nor pay for huge asset pack.)
2. [ ] Check the sound's license to ensure that I can use it.
3. [ ] Import sound into `Sounds/` folder.
4. [ ] Update `Sounds/Attribution.md` doc. Give credit where it's due!
5. [ ] Expose new reference in the `AllTheSounds` ScriptableObject, and hook up the `AudioClip`.
6. [ ] Expose game event for when you want the sound to be played.
* For example, the `PlayerAnimationEvents` script exposes player animation events to C#.
7. [ ] Make `SoundManager` listen to the new game event, and play the corresponding sound when the event occurs.

@nucleartide nucleartide changed the title Add sound effects to all existing mechanics Add sound effect process Apr 4, 2023
@nucleartide nucleartide changed the title Add sound effect process Add mine sound effect + sound effect process Apr 4, 2023
@nucleartide nucleartide marked this pull request as ready for review April 4, 2023 11:45
@nucleartide nucleartide merged commit 8437989 into master Apr 4, 2023
@nucleartide nucleartide deleted the jason/add-sound-effects-to-all-mechanics branch April 4, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant