Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collect water sound #45

Merged
merged 6 commits into from
Apr 6, 2023
Merged

Conversation

nucleartide
Copy link
Owner

@nucleartide nucleartide commented Apr 6, 2023

Workflow

  1. Update readme with pull request link so that the diff enables opening a pull request.
  2. Find sound effects from freesound.org.
  3. Check the sound's license to ensure that I can use it.
  4. Import sound into Sounds/ folder.
  5. If desired, combine sounds into one using Audacity.
  6. Update Sounds/Attribution.md doc.
  7. Expose new reference in the AllTheSounds ScriptableObject, and hook up the AudioClip. Alternatively, if you want to play the sound as its own AudioSource, then create the AudioSource and hook up the AudioClip. This decision is made based on how frequently the sound is played, though eventually we may just refactor to use a more robust third-party SoundManager.
  8. Add test methods to SoundManager (or a separate script) that play the sound. If the audio clip is split into many sections, identify sections within the audio clip to play with the AudioClipSection class, then use AudioSourceHelpers.PlaySoundInterval.
  9. Expose game event for when you want the sound to be played. For example, the PlayerAnimationEvents script exposes player animation events to C#. You may need to also impose certain conditions for playing the sound.
  10. Make SoundManager (or your separate script) listen to the new game event, and call the corresponding play-sound method when the event occurs.

@nucleartide nucleartide marked this pull request as ready for review April 6, 2023 21:11
@nucleartide nucleartide merged commit 5a65b0b into master Apr 6, 2023
@nucleartide nucleartide deleted the jason/add-collect-water-sound branch April 6, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant