Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow const in enamldefs that uses the ReadOnly member #545

Closed
frmdstryr opened this issue Mar 6, 2024 · 5 comments
Closed

Comments

@frmdstryr
Copy link
Contributor

It would be nice to be able use const instead of a normal attr that uses a Constant member so the value can't be changed from the initial value.

If you think this would be ok, I'd be willing to submit a PR.

@MatthieuDartiailh
Copy link
Member

I will have to check how const is currently used. I am on my phone and could not remember/find what we do with it.

@sccolbert
Copy link
Member

sccolbert commented Mar 6, 2024 via email

@MatthieuDartiailh
Copy link
Member

I know it has been a long time but could you explain a bit the reasoning behind const in template. Looking at the advanced example it get it serves to generate temporary bindings within the template body but is it all there is to it ?

Personally, I would not be against allowing const in enamldef with a different meaning from the one it takes in templates. And I should try to document templates because even to me there are obscure.

@sccolbert
Copy link
Member

sccolbert commented Mar 22, 2024 via email

@sccolbert
Copy link
Member

sccolbert commented Mar 22, 2024 via email

@frmdstryr frmdstryr changed the title Feature request: Allow const in enamldefs that uses the Constant member Feature request: Allow const in enamldefs that uses the ReadOnly member Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants