New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix live_editor.enaml example for Qt5 #230
Conversation
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=========================================
+ Coverage 60.52% 62.82% +2.3%
=========================================
Files 289 289
Lines 23304 23308 +4
=========================================
+ Hits 14104 14643 +539
+ Misses 9200 8665 -535
Continue to review full report at Codecov.
|
Not sure this is the right fix for this. |
I am not a big fan of fixing the issue in this way. Also could you point to a way to get QScintilla packaged with PyQt5 such that I add this to the build matrix. |
Redid it in a proper way. Also updated the test and travis. I'm not sure why travis failed on 3.6, the errors seem unrelated. Edit: The magic blank line "fixed" it. |
Looks good to me. I'll let Matthieu make the call on the build script. |
Looks good to me. I will squash and merge and update the release notes. I will also increase the tests timeout to avoid the random failures on Travis. |
No description provided.