Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix live_editor.enaml example for Qt5 #230

Merged
merged 5 commits into from Nov 15, 2017

Conversation

frmdstryr
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 14, 2017

Codecov Report

Merging #230 into master will increase coverage by 2.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #230     +/-   ##
=========================================
+ Coverage   60.52%   62.82%   +2.3%     
=========================================
  Files         289      289             
  Lines       23304    23308      +4     
=========================================
+ Hits        14104    14643    +539     
+ Misses       9200     8665    -535
Impacted Files Coverage Δ
enaml/qt/qt_scintilla.py 86.86% <100%> (+86.86%) ⬆️
enaml/qt/scintilla_lexers.py 87.09% <100%> (+87.09%) ⬆️
enaml/core/parser/base_parser.py 69.62% <0%> (+0.19%) ⬆️
enaml/qt/docking/q_dock_item.py 58% <0%> (+0.28%) ⬆️
enaml/qt/docking/q_dock_container.py 36.05% <0%> (+0.72%) ⬆️
enaml/qt/docking/q_dock_title_bar.py 62.45% <0%> (+1.18%) ⬆️
enaml/qt/docking/layout_builder.py 34.4% <0%> (+1.92%) ⬆️
enaml/qt/docking/q_dock_area.py 73.28% <0%> (+2.05%) ⬆️
enaml/layout/linear_box_helper.py 91.46% <0%> (+2.43%) ⬆️
enaml/layout/dock_layout.py 78.86% <0%> (+3.65%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f7fc2d...6d6ad60. Read the comment docs.

@sccolbert
Copy link
Member

Not sure this is the right fix for this.

@MatthieuDartiailh
Copy link
Member

I am not a big fan of fixing the issue in this way. Also could you point to a way to get QScintilla packaged with PyQt5 such that I add this to the build matrix.

@frmdstryr
Copy link
Contributor Author

frmdstryr commented Nov 14, 2017

Redid it in a proper way. Also updated the test and travis.

I'm not sure why travis failed on 3.6, the errors seem unrelated. Edit: The magic blank line "fixed" it.

@sccolbert
Copy link
Member

Looks good to me. I'll let Matthieu make the call on the build script.

@MatthieuDartiailh
Copy link
Member

Looks good to me. I will squash and merge and update the release notes. I will also increase the tests timeout to avoid the random failures on Travis.
I will wait a month before cutting a new bugix release to see if people find other bugs in the new version.

@MatthieuDartiailh MatthieuDartiailh merged commit a0d86d9 into nucleic:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants