Fix template instance operator binding. #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template instance operator binding require some extra work compared to conventional operator binding since we need both the node where the template is instantiated and where it is defined (I think) however the same analysis in term of globals and comprehensions apply which was not done previously.
Codecov Report
@@ Coverage Diff @@
## main #445 +/- ##
=======================================
Coverage 73.47% 73.47%
=======================================
Files 316 316
Lines 24060 24061 +1
=======================================
+ Hits 17677 17678 +1
Misses 6383 6383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template instance operator binding require some extra work compared to conventional operator binding since we need both the node where the template is instantiated and where it is defined. However the analysis of globals and comprehensions performed for standards operators apply but was not carried out previously. This bug has been there for quite some time and was likely introduced when migrating to Python 3.
This needs tests before it can be merged.