Drop use of Qt compiled resource file #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyQt6 no longer supports *.rcc files. Just load the images directly. Also, switched to QPixmap for rendering the compass rose since that seems to be the preferred class for on-screen rendering.
Codecov Report
@@ Coverage Diff @@
## main #488 +/- ##
==========================================
- Coverage 73.16% 73.15% -0.02%
==========================================
Files 317 316 -1
Lines 24125 24115 -10
Branches 55 55
==========================================
- Hits 17652 17642 -10
Misses 6473 6473 |
|
Nice ! I do not get why we see a segfault after pytest complete on 3.10 with pyside 6 on Linux. It is unrelated to this changes and should not block merging this. |
|
#486 managed to pass at least once. Hopefully it fixes the issue (I restarted the build to see if it keeps on passing). |
|
@MatthieuDartiailh I also don't have the bandwidth to debug the pyside issue. This is likely a problem in the pyside library, but can't say for sure. I don't have any additional Qt6 fixes pending at the moment. I think both #486 and this one are ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyQt6 no longer supports *.rcc files. Just load the images directly.
Also, switched to QPixmap for rendering the compass rose since that
seems to be the preferred class for on-screen rendering.
Fixes #487