-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt: fix loading dock images #503
Conversation
We test directly the loading since we cannot test D&D on the dock area
ping @bburan since you worked on the previous patch |
Codecov Report
@@ Coverage Diff @@
## main #503 +/- ##
==========================================
- Coverage 74.47% 71.30% -3.17%
==========================================
Files 317 308 -9
Lines 24121 22014 -2107
Branches 55 3489 +3434
==========================================
- Hits 17964 15697 -2267
+ Misses 6157 5420 -737
- Partials 0 897 +897 |
I think the test is just accessing the member not triggering the factory? It would be good to call the layout method to get a little coverage. |
I meant to access the guide on an instance... I added calls to layout |
What is the bug here? The only fix I see is to get rid of the import for QDir? Ah, I got it. It has to do with dock_images not getting included in the distribution, right? |
It has to do with the fact that we need a valid package for |
@MatthieuDartiailh I see. For some odd reason I can't replicate the issue. On Python 3.9 at least it seems to automatically add a Either case, I see no reason to hold off on this PR. |
Just tested on a clean setup of Python 3.8 and I can replicate the bug. Applying this patch fixes the bug. Interesting. Probably a newer version of setuptools or setuptools_scm (that gets installed on Python 3.9) is smart enough to auto-create the |
Thanks for testing thoroughly. I will merge and try to do a patch release ASAP. |
We test directly the loading since we cannot test D&D on the dock area
This is extremely annoying and I will do my best to release a patch version ASAP