-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt: attempt to fix PySide6 multi-inheritance issues #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
==========================================
- Coverage 73.38% 72.65% -0.74%
==========================================
Files 296 287 -9
Lines 26001 24417 -1584
Branches 4401 4343 -58
==========================================
- Hits 19081 17740 -1341
+ Misses 5831 5591 -240
+ Partials 1089 1086 -3 |
b45aeb9
to
8a2df55
Compare
…in recent versions
The old config worked for Qt5 but not Qt6 so we simply added the package that existed previously to both intallation scheme that include some extra packages for Qt6
Reasons are unclear but the test pass locally
@bburan I believe I managed to stabilize the CIs. I will merge this and cut the new release tomorrow if nothing goes sideways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.