Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullptr revert #145

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Nullptr revert #145

merged 4 commits into from
Jul 13, 2022

Conversation

MatthieuDartiailh
Copy link
Member

This should work with 3.11b4 and fix #144

This reverts commit 4a568b7fb6ef9996181013b960a18ceec56d8889, reversing
changes made to 13b6186.
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #145 (e92d96e) into main (6269dec) will increase coverage by 3.64%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   87.40%   91.05%   +3.64%     
==========================================
  Files          24       23       -1     
  Lines        1604     1386     -218     
  Branches       74       74              
==========================================
- Hits         1402     1262     -140     
+ Misses        184       69     -115     
- Partials       18       55      +37     

@MatthieuDartiailh MatthieuDartiailh merged commit c782d1d into main Jul 13, 2022
@MatthieuDartiailh MatthieuDartiailh deleted the nullptr-revert branch July 13, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed building wheel for kiwisolver :(
2 participants