Improve test coverage #56
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=========================================
+ Coverage 93.91% 97.1% +3.18%
=========================================
Files 25 25
Lines 1331 1346 +15
=========================================
+ Hits 1250 1307 +57
+ Misses 81 39 -42
Continue to review full report at Codecov.
|
Both from C++ and Python.
This reverts commit 52bea54.
MatthieuDartiailh
force-pushed
the
coverage
branch
from
5d8bc58
to
d3bc4ef
Compare
| @@ -180,7 +181,15 @@ namespace debug | |||
| template<typename T> | |||
| void dump( const T& value ) | |||
| { | |||
| impl::DebugHelper::dump( value ); | |||
| impl::DebugHelper::dump( value, std::cout ); | |||
There was a problem hiding this comment.
Can you make an overload for dump which takes an ostream reference? That may be useful for people.
| /* Dump a representation of the solver internals to a string. | ||
|
|
||
| */ | ||
| std::string dumps() |
There was a problem hiding this comment.
Same thing here, make an overload for ::dump which takes an ostream ref as second arg.
kiwi/solverimpl.h
Outdated
| @@ -605,7 +605,9 @@ class SolverImpl | |||
| Symbol leaving( m_infeasible_rows.back() ); | |||
| m_infeasible_rows.pop_back(); | |||
| RowMap::iterator it = m_rows.find( leaving ); | |||
| if( it != m_rows.end() && it->second->constant() < 0.0 ) | |||
| if( it != m_rows.end() && | |||
| !( allDummies( *it->second ) && nearZero( it->second->constant() ) ) && | |||
There was a problem hiding this comment.
A row with all dummies should be near zero, so that alone should be a sufficient check. No need to iterate the row to check for all dummies.
|
Thanks for the review. |
|
I addressed the comments. I would like to merge and proceed with the release on the 22nd if possible. |
|
Thanks @sccolbert ! |
No description provided.