Replace DompdfWrapperInterface::streamHtml with DompdfWrapperInterface::getStreamResponse #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 22, 2020 10:10
|
Thanks for your PR. This is a major change, because you added a new method to the interface. Can you please remove the deprecated method too |
done |
core23
changed the title
core23
approved these changes
Dec 26, 2020
|
Hello @core23 Are there still concerns to move forward? |
It's fine, you just need to wait. I only have one active development branch (and don't want to maintain more). Merging this PR will result in a major release which I don't want for now. |
This was referenced Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#171
Closes #{171}
Subject
Fixed phpstan error message :
Call to an undefined method Nucleos\DompdfBundle\Wrapper\DompdfWrapperInterface::getStreamResponse().