Fix stimulus init

nucleos · Jul 11, 2021 · b6c8151 · b6c8151
1 parent bc66318
commit b6c8151
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 11 deletions.
diff --git a/assets/dist/googlemaps_controller.js b/assets/dist/googlemaps_controller.js
@@ -49,6 +49,8 @@ var _default = /*#__PURE__*/function (_Controller) {
       var _this = this;
 
       this._prepareApi(this.apiKeyValue).then(function () {
+        _this.element.style.height = _this.heightValue + 'px';
+
         var options = _objectSpread(_objectSpread({}, _this.defaultOptions), {}, {
           latitude: _this.latitudeValue,
           longitude: _this.longitudeValue,
@@ -174,7 +176,7 @@ exports["default"] = _default;
   longitude: Number,
   zoom: Number,
   height: Number,
-  title: Boolean,
+  title: String,
   icon: String,
   apiKey: String
 });
@@ -184,8 +186,5 @@ exports["default"] = _default;
   mapTypeControl: false,
   scaleControl: false,
   draggable: false,
-  scrollwheel: false,
-  title: false,
-  icon: false,
-  apiKey: ''
+  scrollwheel: false
 });
diff --git a/assets/dist/openstreetmap_controller.js b/assets/dist/openstreetmap_controller.js
@@ -96,7 +96,8 @@ var _default = /*#__PURE__*/function (_Controller) {
       var marker = L.marker(position, markerOptions);
 
       if (this.titleValue) {
-        marker.bindPopup(this.titleValue).openPopup();
+        var popup = L.popup().setContent(this.titleValue);
+        marker.bindPopup(popup).openPopup();
       }
 
       return marker;

diff --git a/assets/src/googlemaps_controller.js b/assets/src/googlemaps_controller.js
@@ -8,7 +8,7 @@ export default class extends Controller {
         longitude: Number,
         zoom: Number,
         height: Number,
-        title: Boolean,
+        title: String,
         icon: String,
         apiKey: String,
     };
@@ -20,13 +20,12 @@ export default class extends Controller {
         scaleControl: false,
         draggable: false,
         scrollwheel: false,
-        title: false,
-        icon: false,
-        apiKey: '',
     };
 
     connect() {
         this._prepareApi(this.apiKeyValue).then(() => {
+            this.element.style.height = this.heightValue + 'px';
+
             let options = {
                 ...this.defaultOptions,
                 latitude: this.latitudeValue,

diff --git a/assets/src/openstreetmap_controller.js b/assets/src/openstreetmap_controller.js
@@ -55,7 +55,9 @@ export default class extends Controller {
         const marker = L.marker(position, markerOptions);
 
         if (this.titleValue) {
-            marker.bindPopup(this.titleValue).openPopup();
+            const popup = L.popup().setContent(this.titleValue);
+
+            marker.bindPopup(popup).openPopup();
         }
 
         return marker;