Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix login error #190

Merged
merged 3 commits into from Jan 8, 2021
Merged

Fix login error #190

merged 3 commits into from Jan 8, 2021

Conversation

fkrauthan
Copy link
Contributor

Closes #183

Subject

This added the following changes:

  • Populate all old fields to make the version compatible with a minor version release
  • Fixed the population of username inside the form
  • Switched username and error detection to proper AuthenticationUtils
  • Added CSRF protection to the form (as this is required)

@fkrauthan
Fixed ticket nucleos#183 by creating proper backwards compatibility l…
77e90dc 
…ayer, adding csrf protection, fixing username population and using proper symfony utils
@core23 core23 merged commit 481a838 into nucleos:main Jan 8, 2021
@core23
Copy link
Member

core23 commented Jan 8, 2021

Thanks @fkrauthan this login action looks so much cleaner now.

@core23 core23 added the Bug label Jan 8, 2021
@core23 core23 changed the title Fixed ticket #183 Fix login error Jan 8, 2021
@core23 core23 mentioned this pull request Jan 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 Awaiting requested review from core23

@nucleos-bot nucleos-bot Awaiting requested review from nucleos-bot

Assignees
No one assigned
Labels
Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No form errors after login fail.
2 participants
@fkrauthan @core23