Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find methods could return null #38

Merged
merged 1 commit into from Mar 11, 2020
Merged

Find methods could return null #38

merged 1 commit into from Mar 11, 2020

Conversation

core23
Copy link
Member

@core23 core23 commented Mar 11, 2020

Subject

Call a findGroupBy* could find no group and could return null. Technically an API BC break, but this should have never worked.

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #38   +/-   ##
=========================================
  Coverage     54.34%   54.34%           
- Complexity      480      483    +3     
=========================================
  Files            62       62           
  Lines          1301     1301           
=========================================
  Hits            707      707           
  Misses          594      594
Impacted Files Coverage Δ Complexity Δ
src/Model/GroupManager.php 0% <0%> (ø) 3 <2> (+1) ⬆️
src/Noop/GroupManager.php 0% <0%> (ø) 6 <2> (+1) ⬆️
src/Doctrine/GroupManager.php 0% <0%> (ø) 8 <2> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1178b33...fd05cb6. Read the comment docs.

@core23 core23 merged commit 02e63f9 into master Mar 11, 2020
@core23 core23 deleted the fix-return branch March 11, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

1 participant