Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move configuration to PHP #52

Merged
merged 1 commit into from Jul 4, 2020
Merged

Move configuration to PHP #52

merged 1 commit into from Jul 4, 2020

Conversation

core23
Copy link
Member

@core23 core23 commented Jul 3, 2020

Subject

Allow loading services without XML extension.

@core23 core23 force-pushed the php-files branch 3 times, most recently from beeec87 to e1d1959 Compare July 4, 2020 13:21
@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #52 into main will increase coverage by 6.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #52      +/-   ##
============================================
+ Coverage     55.80%   62.05%   +6.25%     
  Complexity      485      485              
============================================
  Files            62       75      +13     
  Lines          1267     1476     +209     
============================================
+ Hits            707      916     +209     
  Misses          560      560              
Impacted Files Coverage Δ Complexity Δ
src/Noop/GroupManager.php 0.00% <ø> (ø) 6.00 <0.00> (ø)
src/DependencyInjection/NucleosUserExtension.php 88.37% <100.00%> (ø) 31.00 <6.00> (ø)
src/Resources/config/change_password.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Resources/config/commands.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Resources/config/doctrine.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Resources/config/doctrine_group.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Resources/config/flash_notifications.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Resources/config/listeners.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Resources/config/mailer.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Resources/config/noop.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6da880...f84e3d7. Read the comment docs.

@core23 core23 merged commit 58ae309 into main Jul 4, 2020
@core23 core23 deleted the php-files branch August 20, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant