Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds column data to table constraints for mysql & postgres #1029

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

alishakawaguchi
Copy link
Contributor

fixed bug in GetConnectionDataStream where postgres date wasn't being converted to []byte correctly

@alishakawaguchi alishakawaguchi self-assigned this Jan 3, 2024
Copy link

linear bot commented Jan 3, 2024

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview Jan 3, 2024 6:45pm
neosync-marketing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 6:45pm

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (f179496) 58.52% compared to head (2008a42) 58.62%.
Report is 15 commits behind head on main.

Files Patch % Lines
...1alpha1/connection-data-service/connection-data.go 36.73% 31 Missing ⚠️
cli/internal/cmds/neosync/sync/sync.go 3.57% 27 Missing ⚠️
...g/workflows/datasync/activities/benthos-builder.go 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
+ Coverage   58.52%   58.62%   +0.09%     
==========================================
  Files          84       84              
  Lines        8581     8712     +131     
==========================================
+ Hits         5022     5107      +85     
- Misses       2939     2983      +44     
- Partials      620      622       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alishakawaguchi alishakawaguchi merged commit ac939be into main Jan 3, 2024
19 of 20 checks passed
@alishakawaguchi alishakawaguchi deleted the alisha/neos-589 branch January 3, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant