Nick/neos 622 navigating to home page results in no redirect #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nickzelei
commented
Jan 9, 2024
•
nickzelei
commented
- fixes edge case where both user and found are undefined
- makes useSession call require authentication
- handles case where someone puts in bad account in url, will handle redirecting to home page.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nickzelei
commented
Jan 9, 2024
| @@ -58,7 +58,7 @@ export default function AccountProvider(props: Props): ReactElement { | |||
| const foundAccount = accountsResponse?.accounts.find( | |||
| (a) => a.name === accountName | |||
| ); | |||
| if (userAccount?.id === foundAccount?.id) { | |||
| if (userAccount && foundAccount && userAccount?.id === foundAccount?.id) { | |||
There was a problem hiding this comment.
pesky little fucker.
hitting an edge case where userAccount?.id === foundAccount?.id were both undefined which made it equal true.
nickzelei
deleted the
nick/neos-622-navigating-to-home-page-results-in-no-redirect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.