Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular dependencies #1796

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Fix circular dependencies #1796

merged 2 commits into from
Apr 20, 2024

Conversation

alishakawaguchi
Copy link
Contributor

fixes truncate before insert with circular dependencies
fixes ordering issue with circular dependencies

@alishakawaguchi alishakawaguchi self-assigned this Apr 20, 2024
Copy link

vercel bot commented Apr 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2024 5:23am
neosync-marketing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2024 5:23am

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 62.16216% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 17.25%. Comparing base (aea112c) to head (fa6605b).
Report is 2 commits behind head on main.

Files Patch % Lines
cli/internal/cmds/neosync/sync/sync.go 0.00% 10 Missing ⚠️
...run-sql-init-table-stmts/init-statement-builder.go 60.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1796      +/-   ##
==========================================
+ Coverage   17.22%   17.25%   +0.02%     
==========================================
  Files         214      214              
  Lines       45046    45064      +18     
==========================================
+ Hits         7761     7774      +13     
- Misses      36319    36325       +6     
+ Partials      966      965       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant