Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEOS-504 Reworks Transformer(s) Forms to no longer user DTO Type #938

Merged
merged 15 commits into from
Dec 20, 2023
Merged

NEOS-504 Reworks Transformer(s) Forms to no longer user DTO Type #938

merged 15 commits into from
Dec 20, 2023

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Dec 20, 2023 •
edited
Loading

  • Updates schema forms to use values instead of defaultValues to fix accountId missing on page refresh
  • Replaces all uses of JobMappingTransformer on forms with a POJO type
  • Updates /transformers pages to use POJO type instead of TransformerConfig DTO

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 11:02pm

@nickzelei nickzelei changed the title Nick/neos 504 connection schema is buggy and flaky NEOS-504 Reworks Transformer(s) Forms to no longer user DTO Type Dec 20, 2023
@nickzelei nickzelei marked this pull request as ready for review December 20, 2023 23:02
@nickzelei nickzelei merged commit 5c792ab into main Dec 20, 2023
5 checks passed
@nickzelei nickzelei deleted the nick/neos-504-connection-schema-is-buggy-and-flaky branch December 20, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nickzelei