Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix b/w compat chitchat implementation #1109

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix b/w compat chitchat implementation #1109

merged 1 commit into from
Jul 17, 2023

Conversation

vangheem
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@vangheem vangheem requested a review from a team as a code owner July 17, 2023 21:49
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 39.39% and project coverage change: -0.07 ⚠️

Comparison is base (c0e1f1f) 85.39% compared to head (c0d47d6) 85.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
- Coverage   85.39%   85.32%   -0.07%     
==========================================
  Files         404      404              
  Lines       22260    22293      +33     
==========================================
+ Hits        19008    19021      +13     
- Misses       3252     3272      +20     
Flag Coverage Δ
ingest 74.35% <ø> (ø)
nucliadb 66.89% <39.39%> (-0.06%) ⬇️
reader 74.08% <ø> (ø)
sdk 43.17% <ø> (ø)
train 60.33% <ø> (ø)
utils 85.17% <ø> (ø)
writer 84.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...iadb/nucliadb/common/cluster/discovery/chitchat.py 70.58% <39.39%> (-29.42%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vangheem vangheem merged commit c28a787 into main Jul 17, 2023
45 checks passed
@vangheem vangheem deleted the chitchat-bw-compat branch July 17, 2023 22:14
vangheem added a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant