fix s3 delete policy #1550
fix s3 delete policy #1550
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1550 +/- ##
=======================================
Coverage 85.15% 85.15%
=======================================
Files 455 455
Lines 25608 25608
=======================================
Hits 21806 21806
Misses 3802 3802
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Can you explain what the problem was and in which way have you fixed it?
There was a problem hiding this comment.
I can explain @lferran , as i asked Nathan these changes yesterday night: https://github.com/nuclia/backend/pull/1145/files
I fact i see he forgot to add the create bucket changes on this pr i reference.
Also, aside of cypress e2e tests that rely on being able to create a kb and expect that to be deleted "quickly", i think deleting a kb to reuse afterwards shouldn't be a usual problem, but you may need to think about it. There's always the option to iterate the bucket objects and delete them (one by one or in batches of 100 IIRC), but this is time and $ consuming, that's why we do the schedule delete + async delete (on purge) right now.
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.